-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Update code base to use AEDT 24.2 #713
Conversation
@ring630 I just tried to move to AEDT 24.2 and it seems that some examples are not working atm. Did you try the new version yourself ? |
@SMoraisAnsys I tested some of the examples. They are working properly. Which ones are failing for you? |
Can we use a globle variable to specify edb version? |
It's not for me it's for the documentation, see the action log bellow AttributeError: 'bool' object has no attribute 'plot' |
This example works fine on my computer. Error msg in above indicates there is no solution data, which means the design may not be solved. h3d is part of pyaedt. Is it possible the failure is on pyaedt? |
That could be it yeah, we might need to wait for a new release or test with the main branch of pyaedt. |
For more information, see https://pre-commit.ci
…use-aedt-24R2 # Conflicts: # src/pyedb/dotnet/edb_core/hfss.py
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrading our code base to use AEDT 24.2 as default version.
@svandenb-dev @ring630 One of the changes that was performed comes from the fix of @Samuelopez-ansys in 68b393a It seems that AEDT 24.2 has changed the way it works with waveport naming. Previously, it changed the name on the fly and it is not the case anymore with 24.2. The fix consists in mocking what was performed previously with the naming so that 24.1 and 24.2 are both working !